Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: 文档死链 #1986

Open
zxyao145 opened this issue Dec 14, 2023 · 1 comment
Open

bug: 文档死链 #1986

zxyao145 opened this issue Dec 14, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation PR Welcome

Comments

@zxyao145
Copy link

Version

不涉及

OS Version

不涉及

Node.js Version

不涉及

Browser Version

不涉及

Link to minimal reproduction

不涉及

Steps to reproduce

  1. 打开 https://v3.umijs.org/zh-CN/docs/faq

  2. 点击 tsconfig.json 模板:https://github.com/umijs/umi/blob/master/packages/create-umi-app/templates/AppGenerator/tsconfig.json

image

  1. Github 404
    image

What is expected?

在 url 中使用 commit hash,而不是直接使用master分支名。

What is actually happening?

404

Any additional comments? (optional)

No response

Copy link

Hello @zxyao145. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please be sure to fill in the default template in the Pull Request, provide changelog/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @zxyao145,我们完全同意你的提议/反馈,欢迎直接在此仓库创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

@PeachScript PeachScript added the documentation Improvements or additions to documentation label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation PR Welcome
Projects
None yet
Development

No branches or pull requests

2 participants