Skip to content

Move member properties to Member Content App (V9 merge regression) #11768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

ronaldbarendse
Copy link
Contributor

@ronaldbarendse ronaldbarendse commented Dec 16, 2021

Prerequisites

  • I have added steps to test this contribution in the description below

Description

This fixes a regression after merging #11587 to v9, which caused some very minor issues with the new Member Content App change:

  • The 'Is Locked Out' property wasn't using the checkbox/toggle and readonly-state
  • The Member Content App also displayed the 'Id' and 'Member Type' (which were removed, as this is already visible in the Info Content App)

This item has been added to our backlog AB#15619

Sorry, something went wrong.

@ronaldbarendse ronaldbarendse changed the base branch from v9/contrib to v9/dev December 16, 2021 11:09
@bergmania bergmania added release/9.2.0 state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks labels Dec 16, 2021
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nikolajlauridsen nikolajlauridsen merged commit 0ba51f8 into v9/dev Dec 20, 2021
@nikolajlauridsen nikolajlauridsen deleted the v9/bugfix/membership-contentapp branch December 20, 2021 07:45
@umbrabot umbrabot removed the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Dec 20, 2021
nikolajlauridsen pushed a commit that referenced this pull request Jan 4, 2022
…11768)

* Fix regression after merging to v9

* Update test to align with removed member properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants