Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Content Item duplicates when saving twice after create - Happens when Enable list view = true #15945

Open
r-Larch opened this issue Mar 26, 2024 · 3 comments · May be fixed by #16280
Open

[BUG] Content Item duplicates when saving twice after create - Happens when Enable list view = true #15945

r-Larch opened this issue Mar 26, 2024 · 3 comments · May be fixed by #16280
Labels
state/needs-reproduction Check if this can be reproduced in the latest released version type/bug

Comments

@r-Larch
Copy link

r-Larch commented Mar 26, 2024 •
edited

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.2.2 - also happens in 13.1.1

Bug summary

When creating a child content item in a parent where Enable list view = true the item will be duplicated on second Save (not save and publish)

Specifics

Happens in infinite editor.

Steps to reproduce

  • Have a content Item with Vary by culture and Enable list view = true.
  • Add a child content item using Create {Child Page} button. The child is also Vary by culture.
  • Enter a name for the new item
  • Hit Save - not save and publish
  • Make another change to the item.
  • Hit Save again.
    -> You will see name has changed to Name (1) and the item exists twice in the list.

Expected result / actual result

The item will not be duplicated.

Details

It looks like a BUG in the backend.

First save: (node gets an id)
image

Second Save: (the node id gets sent to the backend)
image

Second Save Server response: (the backend responds with a new id!)
image
@github-actions GitHub Actions
Copy link

Hi there @r-Larch!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Zeegaan
Copy link
Member

Zeegaan commented Apr 2, 2024 •
edited

I sadly cannot reproduce this, below is a GIF of me trying to reproduce, am I doing anything wrong here ? 🤔

CantReproduce

@Zeegaan Zeegaan added the state/needs-reproduction Check if this can be reproduced in the latest released version label Apr 2, 2024
@ealse
Copy link

ealse commented May 7, 2024 •
edited

@Zeegaan We got the same problem, but you have to use the infinite editor.
We have had a similar problem in the past and back then I fixed it in this issue: #12874

We are now upgraded from Umbraco version 10.4.0 to 13.3.0 and the problem is back again.

It looks like the problem is the "action" value in the PostSave payload. The id exists but the action is still "action": "saveNew"

Here is an example with a new umbraco 13.3.0 project:
https://github.com/umbraco/Umbraco-CMS/assets/50272817/e316f2e3-0e98-41f8-815f-bd1641ea427d

ealse pushed a commit to ealse/Umbraco-CMS that referenced this issue May 14, 2024
@ebouma
fix: infinite editor stuck in create action (umbraco#15945)
e14f521
@ealse ealse linked a pull request May 14, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state/needs-reproduction Check if this can be reproduced in the latest released version type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V13/bugfix/fix infinite editor stuck in create action 15945 ealse/Umbraco-CMS
3 participants
@r-Larch @ealse @Zeegaan