Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values not populated for properties that vary by culture but not by segment #16186

Closed
dawoe opened this issue Apr 30, 2024 · 5 comments
Closed

Comments

@dawoe
Copy link
Contributor

dawoe commented Apr 30, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.0.0-13.3.0

Bug summary

We have a website running on Umbraco 10.8.5 with uMarketingSuite 2.2.0 for personalization.

We have setup our doctypes to "Allow vary by culture" and "Allow segmentation".
On our documenttypes almost all properties have "Allow vary by culture" enabled and some of them also have "Allow by segmentation" enabled.

On Umbraco 10.8.5 when we viewing a personalized variant, the properties that don't have "Allow by segmentation" enabled will fallback to the current culture value.

After a upgrade to 13.x these properties will return a empty value in that case, similar to this issue #15117

Specifics

I have setup a vanilla Umbraco website running 13.3.0 to see if the issue is reproducable on without uMarketingSuite involved. Unfortunately it is.

I have set up a simple website to reproduce this based on the code from this issue : #15564

Steps to reproduce

  1. Download this zip file and extract it.
  2. Start the website project using dotnet run
  3. Once setup log in to the backoffice with admin@dotcontrol.com / 1234567890
  4. Go to the settings section and import settings using uSync. This will setup a doctype.
  5. Create content for the english language and the customer and visitor segment.
  6. View the content item on the website.
  7. Then append a querystring ?s=customer or ?s=visitor to enable the segmented content and see that property that does not Allow segmentation does not return a value.

Expected result / actual result

I would expect that properties that do not allow segmentation would return the the value from the culture like in Umbraco 10.8.5

No segment enabled while viewing content :
image

Customer segment enabled through querystring
image

Visitor segment enabled through querystring
image

@dawoe dawoe added the type/bug label Apr 30, 2024
Copy link

Hi there @dawoe!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@dawoe
Copy link
Contributor Author

dawoe commented May 7, 2024

@umbraco/cms-group any update on this

@kjac kjac self-assigned this May 8, 2024
@kjac
Copy link
Contributor

kjac commented May 8, 2024

Hi @dawoe - thanks for reaching out. I'll look into this today 👍

@kjac
Copy link
Contributor

kjac commented May 13, 2024

PR in #16270

@kjac kjac added status/regression state/in-sprint We've committed to work on this during the sprint indicated in the milestone state/reproduced area/backend affected/v13 labels May 13, 2024
@bergmania bergmania added release/13.3.1 and removed state/in-sprint We've committed to work on this during the sprint indicated in the milestone state/reproduced area/backend affected/v13 labels May 13, 2024
@kjac
Copy link
Contributor

kjac commented May 15, 2024

Fjxed in #16270 - thanks again for reporting, @dawoe ❤️

@kjac kjac closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants