Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panda emoji and other images load with a white rectangle outline. #250

Closed
Tracked by #241
alextes opened this issue Nov 11, 2022 · 2 comments
Closed
Tracked by #241

Panda emoji and other images load with a white rectangle outline. #250

alextes opened this issue Nov 11, 2022 · 2 comments

Comments

@alextes
Copy link
Collaborator

alextes commented Nov 11, 2022 •
edited

We upgraded to Next13. Next13 replaces the next/image component that we heavily depended on with what was previously next/image/next. Whereas the previous next/image is now next/image/legacy.

The new one has some improvements we'd like to use, but it also suffers from a white outline bug in Safari. Let's wait with the upgrade until it's fixed.

vercel/next.js#40615

I have given the proposed workaround a shot but it doesn't appear to work.
@alextes alextes mentioned this issue Nov 11, 2022
Open
66 tasks
@alextes
Copy link
Collaborator Author

alextes commented Nov 12, 2022

Ran a codemod that keeps us on Next13 but rewrites all next/image use to be next/image/legacy.

Deployed to staging.

@alextes alextes closed this as completed Nov 12, 2022
@alextes alextes changed the title The panda emoji (and other emojis) load with a white rectangle outline. Images load with a white rectangle outline. Nov 12, 2022
@alextes alextes changed the title Images load with a white rectangle outline. Panda emoji and other images load with a white rectangle outline. Nov 12, 2022
@alextes
Copy link
Collaborator Author

alextes commented Nov 12, 2022

Tracking the upgrade to the new image in #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alextes