New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cross-architecture testing to GitHub Actions. #551
Conversation
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 6 6
Lines 1824 1824
=======================================
Hits 1675 1675
Misses 149 149 Continue to review full report at Codecov.
|
Nope. Travis comfortably wins that race. |
That's not so bad, not like 20 minutes or something, and especially as the existing GHA Windows job takes 7 minutes. |
(Actually that 7 minutes is a bit of an outlier, Windows normally takes around 2 minutes.) |
caac120
to
b214ba3
Compare
Hmm, ugly hack required to circumvent setuptools-scm (no idea why doing it properly didn't work - it's runs fine locally) but switching to Alpine did manage it in 2 minutes for most architectures and 3:20 for powerpc. What do you think? We loose MIPS but we didn't have MIPS on TravisCI either. |
MIPS/mips64le: fine to skip that, as you say we didn't have it on Travis, and we have Ugly hack: without it, it failed with:
|
Ahh, now I see what the fuss is all about.
The |
e4713b5
to
b83a39a
Compare
b83a39a
to
f7e66dc
Compare
Ugly hack is gone 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh yes. I do like deleting things! |
I've deleted Travis CI from the branch protection rules: https://github.com/ultrajson/ultrajson/settings/branches -> https://github.com/ultrajson/ultrajson/settings/branch_protection_rules/19228702 Thanks! |
Fixes our aspirations of getting away from TravisCI.
Add GitHub Actions testing of quirky architectures using docker+qemu emulation. I'm temporarily leaving the equivalent
.travis.yml
un-deleted so we can watch the two race each other.