Fix memory leak dumping on non-string dict keys #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For bytes, there was an extraneous INCREF; PyIter_Next returns a new reference. For other non-strings, the original itemName before converting to a string was never dereferenced. Fixes ultrajson#419
Codecov Report
@@ Coverage Diff @@
## main #521 +/- ##
==========================================
+ Coverage 90.63% 90.69% +0.06%
==========================================
Files 6 6
Lines 1783 1784 +1
==========================================
+ Hits 1616 1618 +2
+ Misses 167 166 -1
Continue to review full report at Codecov.
|
bwoodsend
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
bytes, there was an extraneousINCREF;PyIter_Nextreturns a new reference. For other non-strings, the originalitemNamebefore converting to a string was never dereferenced.Fixes #419