Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var to control stripping debug info #507

Merged
merged 2 commits into from Feb 15, 2022

Conversation

musicinmybrain
Copy link
Contributor

Before this commit, debug info is stripped unconditionally on Linux.

This commit adds an environment variable UJSON_BUILD_NO_STRIP that disables this behavior. This is helpful for distribution packagers who would otherwise have to patch setup.py to prevent stripping.

Fixes #506

Changes proposed in this pull request:

  • When environment variable UJSON_BUILD_NO_STRIP is set to 1 or True, do not strip debug symbols from the compiled extension. When it is unset, or set to any other value, maintain the previous behavior of stripping them if the platform is Linux.

musicinmybrain and others added 2 commits February 14, 2022 12:14
Before this commit, debug info is stripped unconditionally on Linux.

This commit adds an environment variable `UJSON_BUILD_NO_STRIP` that disables this behavior. This is helpful for distribution packagers who would otherwise have to patch `setup.py` to prevent stripping.
@bwoodsend bwoodsend merged commit 097284e into ultrajson:main Feb 15, 2022
@bwoodsend
Copy link
Collaborator

Thanks @musicinmybrain!

@hugovk
Copy link
Member

hugovk commented Feb 15, 2022

@bwoodsend I should document this somewhere (perhaps in RELEASING.md?):

Let's always add one of the Changelog: x labels to PRs, such as Changelog: Added for this.

Then the Release Drafter action will create/update the next release notes draft, and put the PR title in the appropriate section. It also takes care of the next SemVer number!

Please can you check you can see the current 5.2.0 draft at https://github.com/ultrajson/ultrajson/releases ?

@bwoodsend bwoodsend added the changelog: Added For new features label Feb 15, 2022
@bwoodsend
Copy link
Collaborator

Oh that's how your changelog works. Yes I see it. I've added the label although it appears to have picked up this change anyway?

@hugovk
Copy link
Member

hugovk commented Feb 15, 2022

Yep, when it ran earlier it just added this with no section header.

It runs when PRs are merged (but can also be triggered) and will overwrite the draft based on all the merged but unreleased PRs.

So the next time it runs it'll update the section.

Sometimes I'll edit PR titles before merge so they make nicer changeling entries. Just before release, the draft can be fine tuned if necessary, but usually it's not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: an easy way to opt out of stripping debug symbols
3 participants