Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSONDecodeError #498

Merged
merged 3 commits into from Feb 5, 2022
Merged

Add JSONDecodeError #498

merged 3 commits into from Feb 5, 2022

Conversation

JustAnotherArchivist
Copy link
Collaborator

Fixes #497

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2022 •
edited

Codecov Report

Merging #498 (cc67f37) into main (ca1fd23) will decrease coverage by 0.17%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   88.96%   88.78%   -0.18%     
==========================================
  Files           6        6              
  Lines        1685     1694       +9     
==========================================
+ Hits         1499     1504       +5     
- Misses        186      190       +4
Impacted Files Coverage Δ
python/ujson.c 72.72% <42.85%> (-5.66%) ⬇️
python/JSONtoObj.c 86.41% <100.00%> (ø)
tests/test_ujson.py 99.54% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1fd23...cc67f37. Read the comment docs.

@hugovk
Copy link
Member

hugovk commented Feb 5, 2022

Thanks for the PR!

Please could you also add a test to check JSONDecodeError is a ValueError?

@hugovk hugovk mentioned this pull request Feb 5, 2022
Closed
@hugovk hugovk added the changelog: Added For new features label Feb 5, 2022
@JustAnotherArchivist
Copy link
Collaborator Author

Good point! Done.

@bwoodsend bwoodsend merged commit 316d384 into ultrajson:main Feb 5, 2022
@bwoodsend
Copy link
Collaborator

Nice one @JustAnotherArchivist

@JustAnotherArchivist JustAnotherArchivist mentioned this pull request Feb 5, 2022
Merged
@hugovk hugovk changed the title Add JSONDecodeError Add JSONDecodeError Feb 6, 2022
cclauss added a commit to cclauss/internetarchive that referenced this pull request Apr 24, 2022
@cclauss
utils.py: ujson now defines a JSONDecodeError
dfcc5e0 
Fixed in ultrajson/ultrajson#498
@cclauss cclauss mentioned this pull request Apr 24, 2022
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: Added For new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decoding exceptions thrown by ujson are not drop-in compatible
4 participants
@JustAnotherArchivist @codecov-commenter @hugovk @bwoodsend