New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip debugging symbols from Linux binaries #493
Conversation
Ahh, I see that this doesn't work on macOS after all... |
Doing so reduces the size of the package at the expense of being less friendly to debug using gdb (GNU's debugger).
5a86278
to
b9275f7
Compare
for more information, see https://pre-commit.ci
In hindsight, I really should have suggested this before the major version bump in case this knocks out some quirky Linux distribution that normally has to install ujson from source. |
Thanks! I guess we could always put this out right away as 6.0.0, but maybe a quick 5.1.0 with just this will be fine and we can revert and/or major bump if needed. |
Quick comparison of Linux wheel sizes, https://test.pypi.org/project/ujson/4.3.1.dev8/#files vs. https://test.pypi.org/project/ujson/5.0.1.dev3/#files:
That's 37% smaller on average: smallest saving 11%, largest 80%. |
@hugovk Can you ping me an email (address is on my profile)? Someone is trying to ask about a security issue in ultrajson but I don't have any contact info for you so I can't copy you in. |
Yep, will do. |
Fixes nothing.
Changes proposed in this pull request:
Apply strip to remove all debugging only symbols from binaries. Doing so reduces the size of the package (around 250KB reduces to 50KB on Linux) at the expense of being less friendly to debug using gdb (GNU's debugger) (ever use C debuggers when using ujson?).