Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for soon-EOL Python 3.6 #490

Merged
merged 1 commit into from Dec 14, 2021
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 22, 2021

Changes proposed in this pull request:

cycle latest release eol
3.10 3.10.0 2021-10-04 2026-10-04
3.9 3.9.9 2020-10-05 2025-10-05
3.8 3.8.12 2019-10-14 2024-10-14
3.7 3.7.12 2018-06-27 2023-06-27
3.6 3.6.15 2016-12-23 2021-12-23

Here's the pip installs for ujson from PyPI for October 2021:

category percent downloads
3.7 78.51% 15,547,674
3.9 6.54% 1,294,795
3.8 6.12% 1,210,988
null 3.66% 724,945
3.6 3.66% 724,471
2.7 1.26% 248,535
3.5 0.16% 32,165
3.10 0.10% 19,036
3.4 0.00% 248
3.11 0.00% 26
3.3 0.00% 18
Total 19,802,901

Date range: 2021-10-01 - 2021-10-31

Source: pip install -U pypistats && pypistats python_minor ujson --last-month

TODO

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #490 (53a28fa) into main (6833495) will not change coverage.
The diff coverage is n/a.

❗ Current head 53a28fa differs from pull request most recent head bd66c08. Consider uploading reports for the commit bd66c08 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   88.96%   88.96%           
=======================================
  Files           6        6           
  Lines        1685     1685           
=======================================
  Hits         1499     1499           
  Misses        186      186           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6833495...bd66c08. Read the comment docs.

bwoodsend added a commit to bwoodsend/ultrajson that referenced this pull request Nov 29, 2021
bwoodsend added a commit to bwoodsend/ultrajson that referenced this pull request Nov 29, 2021
@hugovk hugovk added the changelog: Removed For now removed features label Nov 29, 2021
@hugovk
Copy link
Member Author

hugovk commented Nov 29, 2021

Will merge this and #491 in December, to coincide with 3.6 EOL month.

Will likely release before the actual EOL date, the previous 3.6-compatible versions will still be available on PyPI and python_requires will help out.

@hugovk hugovk merged commit 269621b into ultrajson:main Dec 14, 2021
@hugovk hugovk deleted the rm-3.6 branch December 14, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Removed For now removed features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants