New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gcov coverage testing for C code #457
Conversation
I love how quick your CI is btw. Over on PyInstaller it's 8 hours a run with no parallelizing if two people submit a PR within 8 hours of each other. |
I was only waiting for your confirmation here. So ideally the testing with coverage whoo hah would have just been conditionally adding: env:
CFLAGS: '-coverage -Og' to the |
As far as I'm aware, Codecov has not been used on this org or repo before. I've checked https://app.codecov.io/gh/ultrajson/ultrajson/ and it says no action needed, but also to set a token: Is it so a token is required for the bash uploader? Did you set one in your fork? |
Oh, I assumed you already had one so I didn't try to set one up. I just let codecov upload fail on hitting the authentication error when I ran it locally. Shall I create a token then send it to you once I get it working or would you rather do it? |
Actually it doesn't look like I have the permissions to do it anyway. I can set it up for my own fork but it'll only be measuring my fork and published under bwoodsend/ultrajson which isn't much use. |
I've added the Shall we rerun the CI? |
Hmm, it's supposed to be automatic but failing that, I think I'll need to add a line to turn the secret into an environment variable. |
Give it a re-run - see what happens... |
It isn't supported on the older gcc versions used by CI/CD.
Oh it did it! |
I'm surprised that worked though. I thought PRs weren't supposed to be able to use their target repo's secrets. |
Excellent, let's merge! 88.64% is good for a first measurement! Yep, those charts aren't so obvious. I believe it's a visualisation of how much is covered in the root, and then each subdir, and then each file. I don't usually pay much attention. The greener the better! Thank you! |
Fixes #387.
Changes proposed in this pull request:
Here is a CI run with it. I'm guessing that this error is because I'm running from my own fork?
And I ended up having to drop colored reports on Linux because it turns out it's too new a feature to be available on Github's older Ubuntu VMs.