Decrease dict key reference. #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changeset c9f8318 changed how dict items are iterated. As a consequence, a reference to a dict key remains - clear it.
|
Found that this is a duplicate of #270 with the same issues. Closing. |
|
Thanks for the PR! #270 currently has merge conflicts and test failures, and I don't know if/when that PR will be ready, so we've merged other subsets in the meantime, see #270 (review). So I'd be happy to get this merged and released sooner too. Please could you re-open it? |
hugovk
reviewed
Mar 21, 2020
|
Thanks! Travis is under maintenance right now, will check back later on the pending builds. |
|
Travis doesn't want to restart those jobs in https://travis-ci.com/github/ultrajson/ultrajson/builds/154359958, but it's clearly not related to this and they passed in https://travis-ci.org/github/ultrajson/ultrajson/builds/665134263 so let's merge this. Thanks! |
mrunge
added a commit
to mrunge/python-gnocchiclient
that referenced
this pull request
Mar 29, 2021
For details, see ultrajson/ultrajson#394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changeset c9f8318 changed how dict items are iterated. As a consequence, a reference to a dict key remains - clear it.
Fixes #392
Changes proposed in this pull request:
Note: I'm not very familiar with python c-api, and I don't understand why the mentioned changeset triggered the bug.