Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a separators parameter #283

Closed
klahnakoski opened this issue Aug 27, 2017 · 5 comments · Fixed by #557
Closed

Accept a separators parameter #283

klahnakoski opened this issue Aug 27, 2017 · 5 comments · Fixed by #557
Labels
help wanted Extra attention is needed

Comments

@klahnakoski
Copy link

The builtin Python JSON encoder accepts a separators parameter. Adding this to ultrajson can help with achieving byte-wise identical output with that encoder. This could help expose other bugs in the corner cases of encoding.

@roniemartinez
Copy link

Check #82

Apparently, they are not going to add this feature.

@klahnakoski
Copy link
Author

@Code-ReaQtor - sort_keys was added (#161). I imagine it is only a matter of time. 😄

@roniemartinez
Copy link

@klahnakoski yes! But the developers, at the time (3 years ago), are not into implementing the feature. Only them can tell if the decision have changed. 😄

@EhsanKia
Copy link

They said pull request is welcome, which means they are not working on it but anyone is welcomed to add it.

@JustAnotherArchivist
Copy link
Collaborator

I have implemented this locally, but it's using code from #518, so I'm waiting for that to get finalised and merged first.

JustAnotherArchivist added a commit to JustAnotherArchivist/ultrajson that referenced this issue Jun 27, 2022
bwoodsend pushed a commit that referenced this issue Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants