Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph API v2.8 reaches end of life on April 18, 2019 #47

Open
jbrowning opened this issue Mar 20, 2019 · 2 comments
Open

Graph API v2.8 reaches end of life on April 18, 2019 #47

jbrowning opened this issue Mar 20, 2019 · 2 comments

Comments

@jbrowning
Copy link
Contributor

Just an FYI that the v2.8 API endpoint will be EOL soon so the default token_url config will need to be updated.

More details here: https://developers.facebook.com/docs/graph-api/changelog

@Ianleeclark
Copy link

I went looking through this one some more, and this library could realistically hit 3.2 (giving an EOL of April 30 2021). There is one major deviation from the norm, and it's that access tokens will now expire after 90 days of not engaging with the app (see: https://developers.facebook.com/blog/post/2018/05/01/facebook-login-updates-further-protect-privacy/).

Bumping to 3.3 has (what I believe to be a potentially breaking) change:

Unencrypted User and Page access tokens, which were deprecated in 2012, will no longer be accepted by any of our APIs.

I'm really not too familiar with their graph API, but I believe this would require updating the README to notify users to use encrypted credentials (or doing the workflow for them), and, realistically, releasing a breaking change/major version bump.

@ueberauth/developers If y'all have any idea guidance on how I could test this, I'd be happy to make the changes, but I just wanted to drop-off my findings either way.

@doomspork
Copy link
Member

This is pretty serious but I'm rather out-of-touch with Facebook's GraphAPI at this point. I'm open to a PR @Ianleeclark that would address this, how best to test it I'm not entirely sure 🤔

cc @ueberauth/developers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants