Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Tests #4142

Open
shu8 opened this issue Jul 10, 2023 · 0 comments
Open

[Frontend] Tests #4142

shu8 opened this issue Jul 10, 2023 · 0 comments
Labels
bug javascript Pull requests that update Javascript code starter task

Comments

@shu8
Copy link
Member

shu8 commented Jul 10, 2023

Describe the bug
The frontend refactor (#4114, #4095) didn't migrate the snapshot tests.

We should migrate (or, probably more easier to create new ones) the snapshots for the new frontend. See the old tests here: https://github.com/uclapi/uclapi/tree/93c4227e0d72387089241fc805cec319f9ca811d/frontend/test

See https://jestjs.io/docs/snapshot-testing for more details.

Even better would be to do more advanced testing like using the React Testing Library to test for functionality and/or headless browser tests.

Note: If we add headless browser tests, these tests could be done with our https://www.checklyhq.com/ account without having to write full code.

@shu8 shu8 added bug javascript Pull requests that update Javascript code starter task labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug javascript Pull requests that update Javascript code starter task
Projects
None yet
Development

No branches or pull requests

1 participant