Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Duplicated entries in /timetable/personal response #3787

Open
shu8 opened this issue Jan 4, 2022 · 1 comment
Open

[BUG] Duplicated entries in /timetable/personal response #3787

shu8 opened this issue Jan 4, 2022 · 1 comment
Labels

Comments

@shu8
Copy link
Member

shu8 commented Jan 4, 2022

Describe the bug
/timetable/personal seems to be returning each timetable event twice, e.g.,:

{
  "ok": true,
  "timetable": {
    "2022-01-10": [
      {
        "start_time": "16:00",
        "end_time": "18:00",
        "duration": 120,
        "module": {
          "module_id": "COMP0019",
          "name": "Computer Systems",
          "department_id": "COMPS_ENG",
          "department_name": "Computer Science",
          "lecturer": {
           ...
          }
        },
        ...
      },
      {
        "start_time": "16:00",
        "end_time": "18:00",
        "duration": 120,
        "module": {
          "module_id": "COMP0019",
          "name": "Computer Systems",
          "department_id": "COMPS_ENG",
          "department_name": "Computer Science",
          "lecturer": {
           ...
          }
        },
        ...
      }
    ],
    ...
  }
}

To Reproduce
Steps to reproduce the behavior:

  1. Request /timetable/personal endpoint with client_secret and apiKey (with timetable scope)
  2. See duplicated entries

Expected behavior
One entry per event

Additional context
If you have the client_secret and apiKey you can use the docs page to make the request and see the response.

@shu8 shu8 added the bug label Jan 4, 2022
@greenfrogs
Copy link
Contributor

@shu8 I saw in gencache that there are actually multiple modules with the same name (but different module id) assigned to each student. I think it might have to do with this issue, however I am not sure if we or UCL are at fault here (although ever way we will need to fix it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants