Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCL role accounts do not provide employeeid #3528

Open
MaxwellKeeble opened this issue Sep 2, 2021 · 3 comments
Open

UCL role accounts do not provide employeeid #3528

MaxwellKeeble opened this issue Sep 2, 2021 · 3 comments
Assignees

Comments

@MaxwellKeeble
Copy link

MaxwellKeeble commented Sep 2, 2021

Hi team. UCL has "role accounts" which are fully provisioned accounts that are not linked to an individual person. When trying to log in as one of those via UCL API, it throws this error:

image

Could employeeid be made optional?

An example such account is uczxact

@greenfrogs
Copy link
Contributor

greenfrogs commented Sep 2, 2021

Hi Maxwell, good to hear from you again. At the moment it is non-trivial to disable employeeid, we have it marked as a critical field as it is used during the OAuth flow. During the development of uclapi we were given assurances from UCL that employeeid would always be non-null and unique (UPI). In theory we could switch to eppn or cn which should also be unique but we don't know how consistent they are (for example email can change when moving from a student to faculty).

Also we are planning a major upgrade to our production infrastructure between the 11th and 12th September. If we find a workaround solution by then this will be the time we can implement it. But we are concerned people possibly losing access to their accounts if we start checking against a different value.

Maybe @zipy124 @ChristopherHammond13 has a better idea of a workaround.

@greenfrogs
Copy link
Contributor

greenfrogs commented Sep 2, 2021

@MaxwellKeeble could you please login to our staging environment with the account, we have some additional logging enabled for failed logins. We want to try and see if there is an affiliation or group we can add a special rule for.

https://staging.ninja please ignore the certificate error, it is just a temporary bug of our migration.

@greenfrogs greenfrogs self-assigned this Sep 2, 2021
@MaxwellKeeble
Copy link
Author

Hi @greenfrogs, just to confirm (as mentioned in e-mail),

I've logged in with another of our role accounts - uczx001 - just now (approx 2021-09-06 16.40).

It had the same error, hopefully the logs are helpful.

Error 400 - Bad Request.
UCL has sent incomplete headers. If the issues persist please contact the UCL API Team to rectify this. The missing fields are (space delimited): employeeid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants