Use custom user model in RegistrationForm #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Django will use its own default User model when initializing the CreationForm. This will cause FieldErrors to be raised when a customer user model is provided but doesn't contain the same fields as in Django's default implementation. That's why we use the custom user model to instantiate a CreationForm instead. The implementation can now have any fields it wants as long as it's compatible with Django's AbstractUser. Fixes ubernostrum#234
|
I'm going to close this for now because, as noted on #234, I plan to do a major version bump which will completely remove django-registration's dependency on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Django will use its own default User model when initializing the CreationForm.
This will cause FieldErrors to be raised when a customer user model is provided but doesn't contain the same fields as in Django's default implementation.
That's why we use the custom user model to instantiate a CreationForm instead. The implementation can now have any fields it wants as long as it's compatible with Django's AbstractUser.
Fixes #234