Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.26.0 - Update JaegerClientVersion #574

Merged
merged 1 commit into from Apr 16, 2021
Merged

Release 2.26.0 - Update JaegerClientVersion #574

merged 1 commit into from Apr 16, 2021

Conversation

joe-elliott
Copy link
Member

Which problem is this PR solving?

  • Correct JaegerClientVersion in constants.go for 2.26.0

Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott requested a review from a team as a code owner April 16, 2021 17:38
@joe-elliott joe-elliott requested review from objectiser and removed request for a team April 16, 2021 17:38
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #574 (932b9a4) into master (f236141) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files          61       61           
  Lines        3322     3322           
=======================================
  Hits         2941     2941           
  Misses        253      253           
  Partials      128      128           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f236141...932b9a4. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I guess I should've followed the readme when reviewing :-)

@yurishkuro yurishkuro merged commit b63eeee into master Apr 16, 2021
@yurishkuro yurishkuro deleted the 2.26 branch April 16, 2021 18:08
@yurishkuro
Copy link
Member

PS: please don't push temp branches directly into the main repo, we prefer that maintainers also use forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants