Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Reporter default batch size now inherited #571

Merged
merged 1 commit into from Apr 18, 2021
Merged

HTTP Reporter default batch size now inherited #571

merged 1 commit into from Apr 18, 2021

Conversation

raidancampbell
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • HTTP transport batch size no longer overridden from default 100

This resolves #570 where HTTP spans were sent in batches of 1
instead of the documented default of 100.

Signed-off-by: R. Aidan Campbell <aidan.campbell@aexp.com>
@raidancampbell raidancampbell requested a review from a team as a code owner April 14, 2021 20:23
@raidancampbell raidancampbell requested review from vprithvi and removed request for a team April 14, 2021 20:23
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #571 (ccbe781) into master (967f9c3) will decrease coverage by 0.04%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   88.57%   88.53%   -0.05%     
==========================================
  Files          61       61              
  Lines        3318     3322       +4     
==========================================
+ Hits         2939     2941       +2     
- Misses        252      253       +1     
- Partials      127      128       +1     
Impacted Files Coverage Δ
propagation.go 71.22% <50.00%> (-0.63%) ⬇️
config/config.go 95.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ac6dc...ccbe781. Read the comment docs.

@@ -429,7 +429,7 @@ func (rc *ReporterConfig) NewReporter(
func (rc *ReporterConfig) newTransport(logger jaeger.Logger) (jaeger.Transport, error) {
switch {
case rc.CollectorEndpoint != "":
httpOptions := []transport.HTTPOption{transport.HTTPBatchSize(1), transport.HTTPHeaders(rc.HTTPHeaders)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danehan any idea why your original PR #323 set this to 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given @danehan's silence on GitHub the last year, would you consider moving forward with this after a week of no response?

@yurishkuro yurishkuro merged commit fb93505 into jaegertracing:master Apr 18, 2021
@raidancampbell
Copy link
Contributor Author

Is there any release planned soon? I see there was unfortunately already a very recent one. I can pin my versions against master in a pinch, but it's easier to explain myself if there's a tagged version.

@yurishkuro
Copy link
Member

Released 2.27.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Transport sender sends in batches of 1
2 participants