Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JAEGER_TRACEID_128BIT env var #547

Merged
merged 2 commits into from Nov 27, 2020

Conversation

yurishkuro
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #547 (43572e6) into master (1b586b7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   88.51%   88.53%   +0.02%     
==========================================
  Files          61       61              
  Lines        3301     3307       +6     
==========================================
+ Hits         2922     2928       +6     
  Misses        252      252              
  Partials      127      127              
Impacted Files Coverage Δ
config/config.go 95.27% <100.00%> (+0.03%) ⬆️
config/config_env.go 96.77% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b586b7...43572e6. Read the comment docs.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

config/config.go Show resolved Hide resolved
@jpkrohling jpkrohling merged commit 4ab51d8 into jaegertracing:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants