New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional context protections #544
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
+ Coverage 88.46% 88.51% +0.05%
==========================================
Files 61 61
Lines 3285 3301 +16
==========================================
+ Hits 2906 2922 +16
Misses 252 252
Partials 127 127
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand this supersedes #528?
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
New benchmarks with additional protection in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Which problem is this PR solving?
Short description of the changes
isWriteable()
andisSamplingFinalized()
methods on SpanContextsetTagInternal()
andapplySamplingDecision()
to retrieve the context appropriately under lock or notsetSamplingPriority()
to take a*samplingState
and other required paramsTestSpanContextRaces()
Benchmarks
branch
master