Upgrade to OpenTracing Go 1.2 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yurishkuro
commented
Jul 31, 2020
•
yurishkuro
commented
- Resolves Go 1.15: TestThriftSpanLogs errors #524
- Upgrades opentracing-go dependency to 1.2 (https://github.com/opentracing/opentracing-go/releases/tag/v1.2.0)
- Pin some Prometheus client libs in glide.yaml because some of their dependencies moved to go modules with v2, which is not supported by glide.
added 2 commits
July 31, 2020 12:42
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
commented
Jul 31, 2020
| version: ^1 | ||
| version: 1.1 | ||
| - package: github.com/prometheus/procfs | ||
| version: 0.0.6 |
There was a problem hiding this comment.
Newer versions of Prom client have dependencies on libraries using go modules with v2, which does not work with glide. Since this is legacy anyway, I am pinning to the current versions (unfortunately glide doesn't allow updating a single dep).
yurishkuro
commented
Jul 31, 2020
| @@ -403,7 +403,8 @@ func compareTags(t *testing.T, expected, actual *j.Tag, testName string) { | |||
| return | |||
| } | |||
| if expected == nil || actual == nil { | |||
| assert.Fail(t, "one of the tags is nil", testName) | |||
| t.Logf("one of the tags is nil, test=%s, expected=%v, actual=%v", testName, expected, actual) | |||
There was a problem hiding this comment.
the way assert.Fail prints the message was not helpful, so adding explicit log
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
==========================================
- Coverage 89.28% 89.23% -0.06%
==========================================
Files 61 61
Lines 3919 3919
==========================================
- Hits 3499 3497 -2
- Misses 294 295 +1
- Partials 126 127 +1
Continue to review full report at Codecov.
|
vprithvi
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.