override reporter config only when agent host or port was set in env #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ilylia <ilylia@126.com>
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
+ Coverage 88.74% 88.75% +0.01%
==========================================
Files 60 60
Lines 3786 3790 +4
==========================================
+ Hits 3360 3364 +4
Misses 309 309
Partials 117 117
Continue to review full report at Codecov.
|
yurishkuro
reviewed
May 13, 2020
config/config_test.go
Outdated
| @@ -252,6 +252,55 @@ func TestReporter(t *testing.T) { | |||
| assert.Equal(t, "user", cfg.User) | |||
| assert.Equal(t, "password", cfg.Password) | |||
|
|
|||
| // | |||
There was a problem hiding this comment.
Could you please split these into separate, appropriately named tests? There's no reason to keep everything in one function, and it makes it hard to read.
Signed-off-by: ilylia <ilylia@126.com>
ilylia
force-pushed
the
bugfix-reporter-from-env
branch
from
eff4cec
to
f10fbc2
Compare
yurishkuro
approved these changes
May 14, 2020
|
thanks! |
|
@yurishkuro any plans to tag a new version including this fix? |
|
Would you like to create a "Preparing Release" PR as described in RELEASE.md ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
ReporterConfig.reporterConfigFromEnv(), override reporter agent config only when agent host or port was set in env.