Converge on JAEGER_SAMPLING_ENDPOINT env variable #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eundoo Song <eundoo.song@gmail.com>
eundoosong
force-pushed
the
replace_jaeger_sampling_endpoint
branch
from
aec253f
to
41932f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 60 60
Lines 3784 3786 +2
=======================================
+ Hits 3358 3360 +2
Misses 309 309
Partials 117 117
Continue to review full report at Codecov.
|
yurishkuro
reviewed
May 6, 2020
yurishkuro
reviewed
May 6, 2020
| @@ -102,5 +102,5 @@ const ( | |||
|
|
|||
| var ( | |||
| // DefaultSamplingServerURL is the default url to fetch sampling config from, via http | |||
| DefaultSamplingServerURL = fmt.Sprintf("http://localhost:%d/sampling", DefaultSamplingServerPort) | |||
| DefaultSamplingServerURL = fmt.Sprintf("http://127.0.0.1:%d/sampling", DefaultSamplingServerPort) | |||
There was a problem hiding this comment.
It's not a big reason.
I referred to csharp change, 127.0.0.1 was used in both readme.md and code.
JAEGER_SAMPLING_ENDPOINT | The url for the remote sampling conf when
using sampler type remote. Default is http://127.0.0.1:5778/sampling
If you want, we can stay current code since localhost is 127.0.0.1 (except /etc/hosts lookup.)
eundoosong
force-pushed
the
replace_jaeger_sampling_endpoint
branch
from
a897f7f
to
eefb47d
Compare
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Eundoo Song <eundoo.song@gmail.com>
eundoosong
force-pushed
the
replace_jaeger_sampling_endpoint
branch
from
eefb47d
to
3a21be8
Compare
This was referenced May 8, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?