Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink permission requirements for Admin API DescribeCluster endpoint #5683

Open
mantas-sidlauskas opened this issue Feb 22, 2024 · 1 comment
Labels
good first issue Up for grab as first issue to contribute to Cadence project up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute

Comments

@mantas-sidlauskas
Copy link
Contributor

Context

Cadence WEB is using admin.DescribeCluster API call to check if advanced visibility options are available for a cluster.
All admin.* calls require admin level token when OAuth is enabled. This makes WEB unusable for a user who has only "read" level access to specific domain(s).

There are multiple options how to resolve this issue:

  • Change DescribeCluster to require read level, you can't change anything anyway
  • Move this endpoint to "Frontend" API, change WEB to request Frontend API
@demirkayaender demirkayaender added up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute good first issue Up for grab as first issue to contribute to Cadence project labels Feb 26, 2024
@d-vignesh
Copy link
Contributor

Hi @demirkayaender , does this require backend or frontend change. If backend, i would like to work on this, can you please provide some context on what are the required changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Up for grab as first issue to contribute to Cadence project up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute
Projects
None yet
Development

No branches or pull requests

3 participants