Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivityTaskFailed details should more usefully display panics #468

Open
dnathe4th opened this issue Apr 6, 2022 · 0 comments
Open

ActivityTaskFailed details should more usefully display panics #468

dnathe4th opened this issue Apr 6, 2022 · 0 comments

Comments

@dnathe4th
Copy link
Member

The existing modal for viewing details about an event in the History viewer sends a json blob to the prismjs react element, rendering this content with syntax highlighting. Prismjs [reasonably] does no inspection into the elements of the JSON it is passed and merely renders each element of the list on its own line. For ActivityTaskFailed's that resulted from a panic, or some other returned stacktrace, this results in a very lengthy horizontally-scrollable element on the page:

image

A better user experience would detect and render the panic / stacktrace along the existing line breaks and tab characters contained within the string. This would significantly aid in the developer experience of triaging and debugging workflow failures.

I am not sure the exact solution here so did not accompany this request with any code. I don't see an obvious way in prismjs to translate the linebreak and tab escapes in a way that would be amicable to its <code> formatting.

Just to be clear on the ask though, even just respecting the line breaks would be an improvement (as opposed to full golang stacktrace support, which could presumably be added to prismjs directly as other stacktrace formats are supported, namely from java and javascript). Here is a mock up of my ideal:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant