Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A button to cancel workflow along with terminate #306

Open
longquanzheng opened this issue May 6, 2021 · 1 comment
Open

A button to cancel workflow along with terminate #306

longquanzheng opened this issue May 6, 2021 · 1 comment
Labels

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented May 6, 2021

Screen Shot 2021-05-05 at 10 27 43 PM

Right now only `terminate` is supported. In some use cases cancel is needed.

As a workaround, users have to use CLI to cancel their workflows.

@petergardfjall
Copy link

Any plans to address this? Seems like a logical (?) and simple feature to implement.
Termination provides no means for the code to properly clean up. As an example, I discovered that goroutines would leak for terminated workflows awaiting child workflows with ChildWorkflowFuture.Get() so Cancel is probably preferable in most circumstances and Terminate would only be a last resort. Much like kill -INT might be tried prior to a kill -KILL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants