Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing naming convention of MethodRetry annotation doNotRetry parameter #579

Open
mwoss opened this issue Jan 27, 2021 · 0 comments
Open

Comments

@mwoss
Copy link

mwoss commented Jan 27, 2021

Hi all :DD!
I have a question regarding the doNotRetry parameter of MethodRetry annotation. As the name suggests, I would expect this parameter accepts an exception or a list of exceptions that will be used as information for Cadence workers or server to know when do not retry activity exception is thrown.
However, according to the documentation, this annotation parameter is used to tell workers/server on which exception the activity must be retried. This is a contradiction in my opinion.

Looking at clinet code I will assume that the second option is correct. In that case, should doNotRetry parameter be renamed to doRetry or something similar?

Edit: Apologies, I think I was wrong. The parameter does exactly what it should do, but still, documentation is a bit misleading and in my opinion, should be corrected.

Documentation: Java doc - MathodRetry, doNotRetry paramater

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant