Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External Library Models: Adding support for Nullable upper bounds of Generic Type parameters #949

Merged
merged 21 commits into from
Jun 7, 2024

comment

d351cc9
Select commit
Failed to load commit list.
Refresh
Merged

External Library Models: Adding support for Nullable upper bounds of Generic Type parameters #949

comment
d351cc9
Select commit
Failed to load commit list.
Codecov / codecov/project failed Apr 15, 2024 in 0s

85.98% (-0.11%) compared to 09db47a

View this Pull Request on Codecov

85.98% (-0.11%) compared to 09db47a

Details

Codecov Report

Attention: Patch coverage is 72.72727% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 85.98%. Comparing base (09db47a) to head (d351cc9).

Files Patch % Lines
.../uber/nullaway/libmodel/LibraryModelGenerator.java 0.00% 15 Missing ⚠️
...ava/com/uber/nullaway/handlers/StubxCacheUtil.java 78.12% 9 Missing and 5 partials ⚠️
...er/nullaway/handlers/InferredJARModelsHandler.java 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #949      +/-   ##
============================================
- Coverage     86.08%   85.98%   -0.11%     
- Complexity     2018     2023       +5     
============================================
  Files            79       80       +1     
  Lines          6612     6663      +51     
  Branches       1280     1288       +8     
============================================
+ Hits           5692     5729      +37     
- Misses          510      524      +14     
  Partials        410      410

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov