Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSpecify: support annotated type arguments from an enclosing class #836

Open
msridhar opened this issue Sep 29, 2023 · 0 comments
Open

JSpecify: support annotated type arguments from an enclosing class #836

msridhar opened this issue Sep 29, 2023 · 0 comments
Labels
jspecify Related to support for jspecify standard (see jspecify.dev)

Comments

@msridhar
Copy link
Collaborator

See the test NullAwayJSpecifyGenericsTests#overrideAnonymousNestedClass which is ignored since it fails.

Originally posted by @msridhar in #808 (comment)
@msridhar msridhar added the jspecify Related to support for jspecify standard (see jspecify.dev) label Sep 29, 2023
@msridhar msridhar mentioned this issue Sep 29, 2023
Merged
msridhar added a commit that referenced this issue Oct 18, 2023
@msridhar
JSpecify: initial handling of generic enclosing types for inner class…
5355c7c 
…es (#837)

This is a step towards fixing #836. We now properly handle the case of a
generic enclosing type for an inner class type, both in checking
matching of type argument nullability and in pretty-printing for error
messages. We still don't handle `NewClassTree` types correctly which is
why #836 is not yet fixed.

Also fixes a bug in where generics checks were performed for `return`
statements. Previously we would only check generic type arguments if the
top-level nullability of the return type was `@NonNull`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
jspecify Related to support for jspecify standard (see jspecify.dev)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msridhar