Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a microbenchmark for type inference / dataflow #617

Merged
merged 7 commits into from Jul 1, 2022

Conversation

msridhar
Copy link
Collaborator

This will help us to identify performance issues in our dataflow analysis that could improve NullAway's performance on large methods. The benchmark was generated with a script.

@lazaroclapp
Copy link
Collaborator

The benchmark was generated with a script.

If so, do we want to commit the generated code, or add the script itself to our build process and have it add a resources/generated/... directory with this sort of generated test code?

@msridhar
Copy link
Collaborator Author

msridhar commented Jun 30, 2022

If so, do we want to commit the generated code, or add the script itself to our build process and have it add a resources/generated/... directory with this sort of generated test code?

So the script was a one-off hack and was not meant to be generalizable. I don't foresee us doing a lot of tweaking to this benchmark. It's possible that we would want more micro-benchmarks like this one in the future. Maybe we can say that when we want to add a second benchmark, we will bite the bullet and check in the generator scripts and run them during the build? To me, that seems like overkill at this point, and I'd rather just commit the generated code for now.

@msridhar msridhar merged commit da92a36 into uber:master Jul 1, 2022
@msridhar msridhar deleted the manu-dflow-bench-test branch July 1, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants