Fix empty contract arguments #616
Conversation
Fix bug where empty contract arguments would return a singleton array of the contract arguments (empty).
|
|
|
Thanks for the contribution! I see how this fixes a bug in parsing of |
|
This shouldn't be the case because it checks if the first part of the contract clause (before the "->") is blank which is only possible when no args are present. |
Replaced isEmpty() (11) call with trim().isBlank() (1.8)
| @@ -68,6 +68,25 @@ public void basicContractAnnotation() { | |||
| .doTest(); | |||
| } | |||
|
|
|||
| @Test | |||
| public void contractArgsEmpty() { | |||
There was a problem hiding this comment.
Rather than this test, would it be possible to write a separate test that directly calls into the APIs of ContractUtils and asserts that the appropriate string is parsed as intended?
| public void getAntecedentCorrectNumOfArgs() { | ||
| ContractUtils.getAntecedent("->_", tree, analysis, state, symbol, 0); | ||
|
|
||
| verifyNoInteractions(tree, state, analysis, symbol); |
There was a problem hiding this comment.
Can we merge this call into the previous test, as the last line? I don't see why we need a separate test for this
There was a problem hiding this comment.
I'm not quite sure why I even separated them🤔
Fixed a bug where empty contract arguments would return a singleton array of the contract arguments (empty).
before:
after:
Thank you for contributing to NullAway!
Please note that once you click "Create Pull Request" you will be asked to sign our Uber Contributor License Agreement via CLA assistant.
Before pressing the "Create Pull Request" button, please provide the following:
A description about what and why you are contributing, even if it's trivial.
The issue number(s) or PR number(s) in the description if you are contributing in response to those.
If applicable, unit tests.