Handle assertThat in JUnit and Hamcrest. #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
navahgar
commented
Apr 29, 2019
navahgar
commented
- This adds handling of nullness assertions using "assertThat(..., isNotNull())" statements from JUnit (https://junit.org/junit4/javadoc/latest/org/junit/Assert.html) and Hamcrest (https://junit.org/junit4/javadoc/4.12/org/hamcrest/MatcherAssert.html).
- Issue Feature request: Recognize common "assertThat(...).isNotNull()" statements #301
lazaroclapp
approved these changes
Apr 29, 2019
nullaway/src/main/java/com/uber/nullaway/handlers/AssertionHandler.java
Outdated
Show resolved
Hide resolved
| "import javax.annotation.Nullable;", | ||
| "class Test {", | ||
| " private void foo(@Nullable Object a, @Nullable Object b) {", | ||
| " org.hamcrest.MatcherAssert.assertThat(a, org.hamcrest.Matchers.is(" |
There was a problem hiding this comment.
Just add the static imports to make this both easier to read and more representative of idiomatic code:
import static org.hamcrest.MatcherAssert.assertThat;
...
assertThat(a, is(notNullValue));
There was a problem hiding this comment.
Sure, good point. I didn't know about static imports. Updated the tests now.
…aries and matchers to make the code more readable.
|
Looks great to me. Feel free to "Squash and merge" after CI passes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.