New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for optional emptiness support with Rx #308
Added tests for optional emptiness support with Rx #308
Conversation
Did we implement Rx Optional support before? I don’t remember that 🙂 |
No, these cases work without any code changes. except for the #307. |
Is that because the extant Rx handling already picks up and propagates the relevant access paths on the optional parameter? If so, very cool! |
Yeah, |
" .map(optional -> optional.get().toString());", | ||
" observable", | ||
" .filter(optional -> optional.isPresent() || perhaps())", | ||
" // BUG: Diagnostic contains: returning @Nullable expression from method with @NonNull", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message seems inappropriate, so need to make some changes in the code to have the correct error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments on #307 and re-add this one plus that fix (assuming it works, of course)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. And we didn't even need to change the order of the handlers?
What happens if you run this with optional emptiness enabled in monorepo right now? Are there still outstanding issues preventing that switch?
Yeah.
Yeah, I should check this now. |
3b8e01c
to
413476b
Compare
• Added tests for Optional emptiness support with Rx.
• No code change was required for these tests to work.
• Fixes #307