Install GJF hook using a gradle task, rather than a gradlew hack.

[lazaroclapp]

Fixes #297

[lazaroclapp]

No integration test for this either, but I tried:

rm .git/hooks/pre-commit
./gradlew build
less .git/hooks/pre-commit

And also:

rm .git/hooks/pre-commit
./gradlew :nullaway:build
less .git/hooks/pre-commit

[msridhar]

👍

[ZacSweers]

out of curiosity, does this task cache correctly? Or just cheap enough to run every time?

[ZacSweers]

Actually I see here: https://docs.gradle.org/current/userguide/build_cache.html#sec:task_output_caching_details

Some tasks, like Copy or Jar, usually do not make sense to make cacheable because Gradle is only copying files from one location to another. It also doesn’t make sense to make tasks cacheable that do not produce outputs or have no task actions.

I wonder if there's a friendlier way to handle this, such as using the spotless gradle plugin

[lazaroclapp]

This won't be cached, but involves only copying a single 358 bytes file, so checking the cache would not be appreciably faster, I think :) (and makes sure the hook gets re-added if the user removes it somehow). Is there a problem with it I am not seeing?

[msridhar]

@ZacSweers is your concern around build times? Or is there some other problem with this approach?

[ZacSweers]

Mostly concern around build times but fair point that this is probably as expensive as a cache hash check anyway. Fwiw we moved to Spotless in AutoDispose

…

On Mon, Apr 8, 2019 at 11:41 AM Lázaro Clapp ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In build.gradle <#298 (comment)>: > @@ -38,6 +38,7 @@ subprojects { project -> errorproneJavac deps.build.errorProneJavac } project.tasks.withType(JavaCompile) { + dependsOn(installGitHooks) This won't be cached, but involves only copying a single 358 bytes file, so checking the cache would not be any faster, I think :) (and makes sure the hook gets re-added if the user removes it somehow). Is there a problem with it I am not seeing? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#298 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABTEvnq5kPHT-SIqm7-fKyneRF6egcz4ks5ve41VgaJpZM4cfOXF> .