Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gradle task to install pre-commit hook #297

Closed
msridhar opened this issue Apr 5, 2019 · 1 comment
Closed

Use Gradle task to install pre-commit hook #297

msridhar opened this issue Apr 5, 2019 · 1 comment

Comments

@msridhar
Copy link
Collaborator

msridhar commented Apr 5, 2019

Right now we hack gradlew to install our formatting pre-commit hook. #294 remove this in the process of doing a Gradle update. But I think that's good; it was hackish anyway. We should use a Gradle task to do the installation instead. WALA's build.gradle shows how to do it:

https://github.com/wala/WALA/blob/96408b265b2b431f24b221104cfdb89be1c59fd8/build.gradle#L284-L295

We can then make some common Gradle task dependent on installGitHooks to install the hook automatically.

@lazaroclapp
Copy link
Collaborator

100% agreed, but let's not remove it from .gradlew until we have this set up, just for the sake of keeping master green even on new git clones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants