Remove warning about @Nullable var args #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunatelly, it is commong to have wrapper functions that take @nullable var args and e.g. pass them immediately to a formatting/logging third-party method that also takes @nullable var args safely. Because of this, erroring out on `@Nullable T args...` can cause a worse experience than simply letting the local array `args` be considered a `@Nullable` array. I am not too happy with current error reporting after reverting this change, but the alternative blocks too many valid method declarations.
|
cc: @ZacSweers (Skipping 0.7.0 internally due to this, unfortunately) |
msridhar
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunatelly, it is commong to have wrapper functions that take
@nullable var args and e.g. pass them immediately to a formatting/logging
third-party method that also takes @nullable var args safely.
Because of this, erroring out on
@Nullable T args...can cause a worseexperience than simply letting the local array
argsbe considered a@Nullablearray. I am not too happy with current error reporting afterreverting this change, but the alternative blocks too many valid method
declarations.