Add support for methods taking literal constant args in Access Paths. #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msridhar Putting this up for review now, but I actually still have to test it internally and profile the change. Since this adds a bunch of steps to AP-construction, it might have a higher performance impact than that we can justify (if that's the case, we can always enable this for selected methods using library models, trading a small amount of manual configuration for faster performance in the common case, but let's first see what the overhead actually is :) ) |
msridhar
approved these changes
Mar 12, 2019
|
No measurable performance impact, and our internal monorepo builds fine with it, so I am merging this :) |
lazaroclapp
added a commit
that referenced
this pull request
Oct 14, 2021
This builds upon PR #285 by adding support to code like: ``` if (x.get(ZERO) != null && x.get(ZERO).foo() != null) { return x.get(ZERO).foo().bar(); } ``` Where `ZERO` is a compile-time evaluated constant. That is, a `static final` variable or field of primitive or string type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the code below:
This code is safe, but NullAway would miss that before this change, due to
get(0)taking an argument. We handlefoo()(a zero-arguments method) just fine.This patch extends our support for method calls with only literal values (and boxed literal values) being passed as arguments. I don't see a case where this would add unsoundness that isn't present on the zero-args case.