Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and fix some library models #277

Merged
merged 1 commit into from Feb 4, 2019
Merged

Add and fix some library models #277

merged 1 commit into from Feb 4, 2019

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Feb 3, 2019

Fixes #276

Also a couple of our existing models were broken. Fix both the models and the tests

Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msridhar msridhar merged commit 6fe4b11 into master Feb 4, 2019
@msridhar msridhar deleted the ms/obj-non-null-field branch February 4, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants