Optimize library model lookups #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msridhar
commented
Dec 4, 2018
msridhar
commented
Dec 4, 2018
| @@ -208,7 +208,7 @@ private NullnessStore lambdaInitialStore( | |||
| NullnessStore environmentMapping = | |||
| Objects.requireNonNull( | |||
| environmentNullness.getEnvironmentMapping(underlyingAST.getLambdaTree()), | |||
| "no environment stored for lambda " + underlyingAST.getLambdaTree()); | |||
| "no environment stored for lambda"); | |||
There was a problem hiding this comment.
separate, tiny optimization: I saw the string conversion of the lambda tree showing up in profiles
msridhar
force-pushed
the
ms/test-optimizations
branch
from
bfe650d
to
05b2707
Compare
msridhar
changed the title
|
@lazaroclapp this is ready for review |
kageiit
approved these changes
Dec 5, 2018
lazaroclapp
reviewed
Dec 5, 2018
| private static Symbol.MethodSymbol lookupHandlingOverrides( | ||
| Symbol.MethodSymbol symbol, Types types, NameIndexedMap<Boolean> optLookup) { | ||
| if (optLookup.nameNotPresent(symbol)) { | ||
| // no model matching the method name, so we don't need to check for overridden methods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NullAway was spending a lot of time checking if we had library models for methods. This PR optimizes the process in two ways:
Nameobjects, as converting aNameto aStringis actually costly.