Initial support for JDK 11 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msridhar
commented
Dec 3, 2018
| @@ -294,6 +294,11 @@ public void externalInitexternalInitSupportFields() { | |||
|
|
|||
| @Test | |||
| public void generatedAsUnannotated() { | |||
| String generatedAnnot = | |||
There was a problem hiding this comment.
javax.annotation.Generated has disappeared in JDK 11 🙁
There was a problem hiding this comment.
Is there an equivalent? What do people use instead?
There was a problem hiding this comment.
There is javax.annotation.processing.Generated now, though there is no consensus on what to use (see e.g. grpc/grpc-java#3633 for discussion). Here we just use javax.annotation.processing.Generated in our tests if we're on JDK 11
|
@lazaroclapp I don't fully understand the coveralls integration. Any chance you can confirm that it is still configured correctly? Now we will be running two different Travis jobs (and likely will do so for a while) so not sure about what the config should be. |
lazaroclapp
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, only the
:nullaway:testtarget is passing on CI. We need to address issues outlined in #259 to get everything working, and it may be a while before the sample Android app can easily be built. That said, I think this initial level of support is useful and worth landing.