Disable JarInfer handler by default #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subarnob
approved these changes
Dec 3, 2018
Oh for sure. We won't be able to update NullAway internally on JDK 11 until we fix JarInfer. It's just that folks are moving to JDK 11 quickly now and I wanted the key parts of NullAway working sooner rather than later. @lazaroclapp can you take a look at this PR and let me know if you have feedback? |
msridhar
force-pushed
the
ms/jarinfer-disabled-by-default
branch
from
e3309c1
to
10d7bc7
Compare
lazaroclapp
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly so that we can have a somewhat-functional NullAway on JDK 11 sooner (see #259). But also, removing a handler may give a small performance boost. With this change, you need to pass
-XepOpt:NullAway:JarInferEnabled=trueto enable JarInfer.Also, we separate out the JarInfer tests into their own module, so that there is no direct dependence from the
nullawaymodule to thejarinferlibraries. This will enable us to get the:nullaway:testtarget passing on JDK 11 sooner.