/
UnannotatedTests.java
237 lines (226 loc) · 8.63 KB
/
UnannotatedTests.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
package com.uber.nullaway;
import java.util.Arrays;
import org.junit.Test;
public class UnannotatedTests extends NullAwayTestsBase {
@Test
public void coreNullabilitySkipClass() {
defaultCompilationHelper
.addSourceFile("Shape_Stuff.java")
.addSourceFile("excluded/Shape_Stuff2.java")
.addSourceFile("AnnotatedClass.java")
.addSourceFile("TestAnnot.java")
.doTest();
}
@Test
public void skipClass() {
makeTestHelperWithArgs(
Arrays.asList(
"-d",
temporaryFolder.getRoot().getAbsolutePath(),
"-XepOpt:NullAway:AnnotatedPackages=com.uber",
"-XepOpt:NullAway:ExcludedClassAnnotations=com.uber.lib.MyExcluded"))
.addSourceLines(
"Test.java",
"package com.uber;",
"import javax.annotation.Nullable;",
"@com.uber.lib.MyExcluded",
"public class Test {",
" static void bar() {",
" // No error",
" Object x = null; x.toString();",
" }",
"}")
.doTest();
}
@Test
public void skipNestedClass() {
makeTestHelperWithArgs(
Arrays.asList(
"-d",
temporaryFolder.getRoot().getAbsolutePath(),
"-XepOpt:NullAway:AnnotatedPackages=com.uber",
"-XepOpt:NullAway:ExcludedClassAnnotations=com.uber.lib.MyExcluded"))
.addSourceLines(
"Test.java",
"package com.uber;",
"import javax.annotation.Nullable;",
"public class Test {",
" @com.uber.lib.MyExcluded",
" static class Inner {",
" @Nullable",
" static Object foo() {",
" Object x = null; x.toString();",
" return x;",
" }",
" }",
" static void bar() {",
" // BUG: Diagnostic contains: dereferenced expression Inner.foo()",
" Inner.foo().toString();",
" }",
"}")
.doTest();
}
@Test
public void coreNullabilitySkipPackage() {
defaultCompilationHelper.addSourceFile("unannotated/UnannotatedClass.java").doTest();
}
@Test
public void generatedAsUnannotated() {
String generatedAnnot =
(Double.parseDouble(System.getProperty("java.specification.version")) >= 11)
? "@javax.annotation.processing.Generated"
: "@javax.annotation.Generated";
makeTestHelperWithArgs(
Arrays.asList(
"-d",
temporaryFolder.getRoot().getAbsolutePath(),
"-XepOpt:NullAway:AnnotatedPackages=com.uber",
"-XepOpt:NullAway:TreatGeneratedAsUnannotated=true"))
.addSourceLines(
"Generated.java",
"package com.uber;",
generatedAnnot + "(\"foo\")",
"public class Generated { public void takeObj(Object o) {} }")
.addSourceLines(
"Test.java",
"package com.uber;",
"class Test {",
" void foo() { (new Generated()).takeObj(null); }",
"}")
.doTest();
}
@Test
public void generatedAsUnannotatedCustomAnnotation() {
makeTestHelperWithArgs(
Arrays.asList(
"-d",
temporaryFolder.getRoot().getAbsolutePath(),
"-XepOpt:NullAway:AnnotatedPackages=com.uber",
"-XepOpt:NullAway:CustomGeneratedCodeAnnotations=com.uber.MyGeneratedMarkerAnnotation",
"-XepOpt:NullAway:TreatGeneratedAsUnannotated=true"))
.addSourceLines(
"MyGeneratedMarkerAnnotation.java",
"package com.uber;",
"import java.lang.annotation.Retention;",
"import java.lang.annotation.Target;",
"import static java.lang.annotation.ElementType.CONSTRUCTOR;",
"import static java.lang.annotation.ElementType.FIELD;",
"import static java.lang.annotation.ElementType.TYPE;",
"import static java.lang.annotation.ElementType.METHOD;",
"import static java.lang.annotation.ElementType.PACKAGE;",
"import static java.lang.annotation.RetentionPolicy.SOURCE;",
"@Retention(SOURCE)",
"@Target({PACKAGE, TYPE, METHOD, CONSTRUCTOR, FIELD})",
"public @interface MyGeneratedMarkerAnnotation {}")
.addSourceLines(
"Generated.java",
"package com.uber;",
"@MyGeneratedMarkerAnnotation",
"public class Generated { public void takeObj(Object o) {} }")
.addSourceLines(
"Test.java",
"package com.uber;",
"class Test {",
" void foo() { (new Generated()).takeObj(null); }",
"}")
.doTest();
}
@Test
public void unannotatedClass() {
makeTestHelperWithArgs(
Arrays.asList(
"-d",
temporaryFolder.getRoot().getAbsolutePath(),
"-XepOpt:NullAway:AnnotatedPackages=com.uber",
"-XepOpt:NullAway:UnannotatedClasses=com.uber.UnAnnot"))
.addSourceLines(
"UnAnnot.java",
"package com.uber;",
"import javax.annotation.Nullable;",
"public class UnAnnot {",
" @Nullable static Object retNull() { return null; }",
"}")
.addSourceLines(
"Test.java",
"package com.uber;",
"import javax.annotation.Nullable;",
"class Test {",
" @Nullable static Object nullRetSameClass() { return null; }",
" void test() {",
" UnAnnot.retNull().toString();",
// make sure other classes in the package still get analyzed
" Object x = nullRetSameClass();",
" // BUG: Diagnostic contains: dereferenced expression x is @Nullable",
" x.hashCode();",
" }",
"}")
.doTest();
}
@Test
public void overrideFailsOnExplicitlyNullableLibraryModelParam() {
defaultCompilationHelper
.addSourceLines( // Dummy android.view.GestureDetector.OnGestureListener interface
"GestureDetector.java",
"package android.view;",
"public class GestureDetector {",
" public static interface OnGestureListener {",
// Ignore other methods for this test, to make code shorter on both files:
" boolean onScroll(MotionEvent me1, MotionEvent me2, float f1, float f2);",
" }",
"}")
.addSourceLines( // Dummy android.view.MotionEvent class
"MotionEvent.java", "package android.view;", "public class MotionEvent { }")
.addSourceLines(
"Test.java",
"package com.uber;",
"import android.view.GestureDetector;",
"import android.view.MotionEvent;",
"class Test implements GestureDetector.OnGestureListener {",
" Test() { }",
" @Override",
" // BUG: Diagnostic contains: parameter me1 is @NonNull",
" public boolean onScroll(MotionEvent me1, MotionEvent me2, float f1, float f2) {",
" return false; // NoOp",
" }",
"}")
.addSourceLines(
"Test2.java",
"package com.uber;",
"import javax.annotation.Nullable;",
"import android.view.GestureDetector;",
"import android.view.MotionEvent;",
"class Test2 implements GestureDetector.OnGestureListener {",
" Test2() { }",
" @Override",
" public boolean onScroll(@Nullable MotionEvent me1, MotionEvent me2, float f1, float f2) {",
" return false; // NoOp",
" }",
"}")
.doTest();
}
/**
* Ensure we don't crash for a type cast in unannotated code. See
* https://github.com/uber/NullAway/issues/711
*/
@Test
public void typeCastInUnannotatedCode() {
makeTestHelperWithArgs(
Arrays.asList(
"-d",
temporaryFolder.getRoot().getAbsolutePath(),
"-XepOpt:NullAway:AnnotatedPackages=com.other"))
.addSourceLines(
"Test.java",
"package com.uber;",
"import java.util.function.Consumer;",
"import org.junit.Assert;",
"class Test {",
" private void verifyCountZero() {",
" verifyData((count) -> Assert.assertEquals(0, (long) count));",
" }",
" private void verifyData(Consumer<Long> assertFunction) {",
" }",
"}")
.doTest();
}
}