Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configuration] using babel overrides throws error #427

Open
chrisgervang opened this issue Aug 15, 2023 · 0 comments
Open

[configuration] using babel overrides throws error #427

chrisgervang opened this issue Aug 15, 2023 · 0 comments

Comments

@chrisgervang
Copy link
Collaborator

https://github.com/uber-web/ocular/blame/69b7e75378ef249c3e723dc605dc6f7399439bd4/modules/dev-tools/src/configuration/get-babel-config.cjs#L111

I don't think this is functioning as intended. When I use overrides I get an Error: babel.config.js: Configuration should be an exported JavaScript object.

Shouldn't it be something like this?

if (options.overrides) {
  config = deepMerge(config, {overrides: options.overrides});
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant