Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal link gets replaced with undefined or requires odd pathing #229

Open
isaacbrodsky opened this issue Aug 15, 2019 · 1 comment
Open

Comments

@isaacbrodsky
Copy link
Collaborator

Please see uber/h3#274

There were two issues I had with a href links. The first is that when an internal link wasn't resolved, it was replaced with undefined. This silently broke the site, but really should have failed the build. I see the code for Markdown pages has changed in master so I'm not sure if this issue still exists.

The second issue was that for the page /docs/core-library/filters.md to reference /docs/core-library/h3Indexing.md, I need to write the link as ../h3indexing.md (note the .. and that the capitalization changed). I think this may be an issue with documents nested more than one level deep since I didn't see this on the React Vis site. I would have preferred either h3Indexing.md or /docs/core-library/h3Indexing.md.

@isaacbrodsky
Copy link
Collaborator Author

Is there a recommended way to add internal links in ocular-gatsby? @jckr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant