Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish beta didn't properly update dependencies in luma.gl #167

Open
tsherif opened this issue May 13, 2019 · 3 comments
Open

Publish beta didn't properly update dependencies in luma.gl #167

tsherif opened this issue May 13, 2019 · 3 comments

Comments

@tsherif
Copy link
Contributor

tsherif commented May 13, 2019

The incorrect dependencies were manually fixed in this commit: visgl/luma.gl@27f1654

I was publishing a new alpha version of luma.gl and went through the following steps:

  1. Set version in lerna.json to 7.1.0-alpha.0
  2. Run npm run publish beta

My understanding is that this should publish version 7.1.0-alpha.1 and update all internal dependencies accordingly. It did so correctly in most places, but a few of the dependencies were incorrectly set to 7.1.0-alpha.0.

@ibgreen
Copy link
Collaborator

ibgreen commented May 13, 2019

@tsherif
Copy link
Contributor Author

tsherif commented May 13, 2019

Don't we already force publish all modules? It seems to be inconsistent about which dependencies get updated and which don't, e.g. before my fix: https://github.com/uber/luma.gl/blob/241483c0fac705b7ff9f6e4819097a3628fd4ea7/modules/debug/package.json

version is 7.1.0-alpha.1, and dependency on @luma.gl/constants is 7.1.0-alpha.1, but peer dependency on @luma.gl/core is 7.1.0-alpha.0.

@tsherif
Copy link
Contributor Author

tsherif commented May 13, 2019

Actually looking at it now, it looks like it's just the caret (^) versions that aren't updated, which kind of makes sense. But why does it change them to alpha.0 and then not update them further? And what would be the right approach to avoid this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants