Add FilterFieldKey to zaptest/observer #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
=======================================
Coverage 98.26% 98.27%
=======================================
Files 44 44
Lines 1965 1969 +4
=======================================
+ Hits 1931 1935 +4
Misses 27 27
Partials 7 7
Continue to review full report at Codecov.
|
prashantv
approved these changes
Mar 22, 2021
r-hang
force-pushed
the
rhang/filter-field-key
branch
from
855526f
to
fab73a8
Compare
robbertvanginkel
approved these changes
Mar 22, 2021
Adds functionality to filter zap.Field by key. This makes testing for field existence regardless of value more convenient. resolves uber-go#816
r-hang
force-pushed
the
rhang/filter-field-key
branch
from
fab73a8
to
d5cc7f5
Compare
abhinav
approved these changes
Mar 22, 2021
abhinav
pushed a commit
that referenced
this pull request
May 25, 2021
Adds functionality to filter zap.Field by key. This makes testing for field existence regardless of value more convenient. resolves #816
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
Adds functionality to filter zap.Field by key. This makes testing for field existence regardless of value more convenient. resolves uber-go#816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality to filter zap.Field by key. This makes testing for
field existence regardless of value more convenient.
resolves #816