From 028cbced8baf1c414d43bc215c3dbe635e7e3832 Mon Sep 17 00:00:00 2001 From: SteelPhase Date: Fri, 1 May 2020 17:17:01 -0400 Subject: [PATCH 1/3] Add missing new line --- options.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/options.go b/options.go index 59f1b54a0..c05b38117 100644 --- a/options.go +++ b/options.go @@ -125,7 +125,7 @@ func IncreaseLevel(lvl zapcore.LevelEnabler) Option { return optionFunc(func(log *Logger) { core, err := zapcore.NewIncreaseLevelCore(log.core, lvl) if err != nil { - fmt.Fprintf(log.errorOutput, "failed to IncreaseLevel: %v", err) + fmt.Fprintf(log.errorOutput, "failed to IncreaseLevel: %v\n", err) } else { log.core = core } From 52b30f79500fa7b99b97164775b06a6113a8661d Mon Sep 17 00:00:00 2001 From: SteelPhase Date: Fri, 1 May 2020 18:27:36 -0400 Subject: [PATCH 2/3] Fixup unit test to accept newline --- increase_level_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/increase_level_test.go b/increase_level_test.go index 56a23873c..6888fc2ac 100644 --- a/increase_level_test.go +++ b/increase_level_test.go @@ -58,7 +58,7 @@ func TestIncreaseLevelTryDecrease(t *testing.T) { newLoggedEntry(ErrorLevel, "increase level error log"), }, logs.AllUntimed(), "unexpected logs") assert.Equal(t, - `failed to IncreaseLevel: invalid increase level, as level "info" is allowed by increased level, but not by existing core`, + `failed to IncreaseLevel: invalid increase level, as level "info" is allowed by increased level, but not by existing core\n`, errorOut.String(), "unexpected error output", ) From e19f8d375e19a573e969723accb765d6326f52f5 Mon Sep 17 00:00:00 2001 From: SteelPhase Date: Fri, 1 May 2020 18:42:29 -0400 Subject: [PATCH 3/3] Change quoting of string --- increase_level_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/increase_level_test.go b/increase_level_test.go index 6888fc2ac..2d883807e 100644 --- a/increase_level_test.go +++ b/increase_level_test.go @@ -58,7 +58,7 @@ func TestIncreaseLevelTryDecrease(t *testing.T) { newLoggedEntry(ErrorLevel, "increase level error log"), }, logs.AllUntimed(), "unexpected logs") assert.Equal(t, - `failed to IncreaseLevel: invalid increase level, as level "info" is allowed by increased level, but not by existing core\n`, + "failed to IncreaseLevel: invalid increase level, as level \"info\" is allowed by increased level, but not by existing core\n", errorOut.String(), "unexpected error output", )